Skip to content

Don't iterate over all empty slots in the xref entries (bug 1980958) #20170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 25, 2025
Merged

Don't iterate over all empty slots in the xref entries (bug 1980958) #20170

merged 1 commit into from
Aug 25, 2025

Conversation

calixteman
Copy link
Contributor

No description provided.

@calixteman
Copy link
Contributor Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/4ba3f8a994c8f8f/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/b4375f2c361afca/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/b4375f2c361afca/output.txt

Total script time: 56.99 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/4ba3f8a994c8f8f/output.txt

Total script time: 60.00 mins

@timvandermeij
Copy link
Contributor

/botio-linux preview

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/54f5ccde8784ea2/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/54f5ccde8784ea2/output.txt

Total script time: 0.94 mins

Published

timvandermeij
timvandermeij approved these changes Aug 17, 2025
View reviewed changes
Copy link
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with the comments addressed. Thanks!

nicolo-ribaudo
nicolo-ribaudo reviewed Aug 18, 2025
View reviewed changes
nicolo-ribaudo
nicolo-ribaudo reviewed Aug 18, 2025
View reviewed changes
nicolo-ribaudo
nicolo-ribaudo reviewed Aug 18, 2025
View reviewed changes
nicolo-ribaudo
nicolo-ribaudo reviewed Aug 18, 2025
View reviewed changes
timvandermeij
timvandermeij reviewed Aug 18, 2025
View reviewed changes
@timvandermeij
Copy link
Contributor

r=me, with the merge conflict fixed and passing tests. Thanks!

@calixteman
Copy link
Contributor Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/785629be3013d3e/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/cb1cf7475456b0f/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/785629be3013d3e/output.txt

Total script time: 36.96 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/cb1cf7475456b0f/output.txt

Total script time: 88.28 mins

  • Unit tests: FAILED
  • Integration Tests: FAILED
  • Regression tests: Passed

@calixteman calixteman merged commit 7a65c58 into mozilla:master Aug 25, 2025
9 checks passed
@calixteman calixteman deleted the bug1980958 branch August 25, 2025 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timvandermeij timvandermeij timvandermeij approved these changes

+1 more reviewer

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
core performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@calixteman @moz-tools-bot @timvandermeij @nicolo-ribaudo